Skip to content

fix: logout and minor improvements #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 3, 2025
Merged

fix: logout and minor improvements #4177

merged 9 commits into from
Sep 3, 2025

Conversation

blva
Copy link
Collaborator

@blva blva commented Sep 2, 2025 •
edited
Loading

Proposed changes

Clarification change - mentions what profile is being logged out

❯ ./bin/atlas logout -P other-p --debug
? Are you sure you want to log out of account with public API key default from profile other-p? (y/N)

❯ ./bin/atlas logout
? Are you sure you want to clear profile default? (y/N)

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva changed the title fix: fix logout fix: fix logout and minor improvements Sep 2, 2025
@coveralls
Copy link
Collaborator

coveralls commented Sep 2, 2025 •
edited
Loading

Coverage Status

coverage: 64.155% (+0.001%) from 64.154%
when pulling 8aa04ac on sa-logout
into 3326d90 on master.

@blva blva changed the title fix: fix logout and minor improvements fix: logout and minor improvements Sep 2, 2025
@blva blva marked this pull request as ready for review September 2, 2025 16:46
@blva blva requested a review from a team as a code owner September 2, 2025 16:46
cveticm
cveticm reviewed Sep 3, 2025
View reviewed changes
cveticm
cveticm previously approved these changes Sep 3, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % minor nit

internal/cli/auth/logout.go Outdated
@@ -174,14 +174,14 @@ func LogoutBuilder() *cobra.Command {
var message, entry string
var err error

fromProfile := fmt.Sprintf(" from profile %s?", opts.config.Name())
logoutMessage := fmt.Sprintf("Are you sure you want to log out of profile %s ", opts.config.Name())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the space and put the space at the beginning all other messages so noAuth scenario doesn't end with <space><question mark>:
Are you sure you want to log out of profile %s ?

@blva blva requested a review from cveticm September 3, 2025 10:42
cveticm
cveticm reviewed Sep 3, 2025
View reviewed changes
cveticm
cveticm reviewed Sep 3, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@blva blva enabled auto-merge (squash) September 3, 2025 10:59
@blva blva merged commit 88e562a into master Sep 3, 2025
23 of 25 checks passed
@blva blva deleted the sa-logout branch September 3, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cveticm cveticm cveticm approved these changes

Assignees
No one assigned
Labels
atlascli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blva @coveralls @cveticm